Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only remap/add the existing metrics #103

Open
rogercoll opened this issue Oct 1, 2024 · 0 comments
Open

Only remap/add the existing metrics #103

rogercoll opened this issue Oct 1, 2024 · 0 comments

Comments

@rogercoll
Copy link
Contributor

The remappers function is adding all the k8s and system metrics, even if its corresponding feature parity metric does not exist. The newly added metrics are always added if the metric's scope name is matched, see: https://github.com/elastic/opentelemetry-lib/blob/main/remappers/kubernetesmetrics/kubelet.go#L91

kubernetes.pod.cpu.usage.limit.pct should only be added if k8s.pod.cpu_limit_utilization exists, the same should apply to all other mappings. See input and ouput metrics of these example: https://github.com/elastic/opentelemetry-collector-components/tree/f031e2be42a92745b5cb09ee7249b8c1a8191925/processor/elasticinframetricsprocessor/testdata/k8smetrics_drop_original

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant