Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce remap metrics only when the original metrics is present #6

Open
lahsivjar opened this issue May 16, 2024 · 3 comments
Open
Assignees

Comments

@lahsivjar
Copy link
Contributor

Current codebase will produce a zero value remapping for metrics which are missing in the originally scraped metric. Ideally, we should only produce remapped metrics if we have the values present in the original metric.

@ishleenk17
Copy link
Contributor

Resolved in this issue: #36

@ishleenk17 ishleenk17 self-assigned this Jul 4, 2024
@ishleenk17
Copy link
Contributor

The issue should be fixed in a different way.
Reopening it for now.

@ishleenk17 ishleenk17 reopened this Jul 4, 2024
@lahsivjar
Copy link
Contributor Author

When we fix this, we should also log any invalid metric that is being produced as it will point to a bug on our end. This could be done in the remappedmetric/Metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants