Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast and suggest the user to run in --offline if no internet #1468

Closed
dliappis opened this issue Mar 24, 2022 · 0 comments · Fixed by #1503
Closed

Fail fast and suggest the user to run in --offline if no internet #1468

dliappis opened this issue Mar 24, 2022 · 0 comments · Fixed by #1503
Assignees
Labels
enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution

Comments

@dliappis
Copy link
Contributor

While working on #1467 we figured that the current mode of operation which a) validates internet connectivity by
attempting a successful connection to github.com and b) if not true, runs Rally in offline mode

is doing too much implicitly and might be difficult to troubleshoot if the intention is to run normally but there is a small github outage.

Instead an alternative would be that if all retries have failed, we should raise an error and advise the user to specify --offline, if that's what they intend.

@dliappis dliappis added enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers labels Mar 24, 2022
@pquentin pquentin added the help wanted We'd be happy about a community contribution label May 25, 2022
@j-bennet j-bennet self-assigned this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo good first issue Small, contained changes that are good for newcomers help wanted We'd be happy about a community contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants