Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that the shape_id matches the rest of the URL structure #1663

Closed
KyleAMathews opened this issue Sep 10, 2024 · 0 comments · Fixed by #1678
Closed

Validate that the shape_id matches the rest of the URL structure #1663

KyleAMathews opened this issue Sep 10, 2024 · 0 comments · Fixed by #1678
Assignees
Labels

Comments

@KyleAMathews
Copy link
Contributor

This isn't an issue when using the official clients but when hand-constructing shape URLs or when writing a new one, it's possible to write a URL where the various parts don't match each other.

We validate already that the shape_id is the current shape_id for the url structure by returning a 409 if it's not.

We also need to validate that the shape_id is for the shape that the URL describes i.e. if a shape is defined as v1/shape/foo but then the shape_id for that shape def is applied to v1/shape/foo?where='foo=true' then we should return a 400.

Follow-up issue to #1659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants