Recursion in asar. createPackageFromFiles won't handle very large file lists

[johnhaley81]

Introducted in #73.

asar.createPackageFromFiles now uses recursion to handle the list of files which is ok for a reasonable number of files but over in GitKraken we have an unreasonable number of files we're putting into the asar (~100k) which causes a Maximum call stack size exceeded.

As unreasonably large as the that number is, when using node/npm for a large project that no longer really becomes an edge case.

[mingyuan-xia]

This does not need to be a large number. I tested two folders, one with 9.5k and another with 4.7k files. Both failed. Finally, it works with 1.5k files.
I am packing an electron app with asar 0.12.0. With some bower dependencies, the number of files could easily grow to crash asar.

[develar]

@gerhardberger Please fix it ASAP. electron-userland/electron-builder#606

[cmroanirgo]

I am here because of the exact same issue. I use cheerio and jszip in a project. Result: "Call Stack Exceeded", when using electron builder.
I agree that the recursion must go.

[gerhardberger]

@develar I submitted a PR with a fix. I tested with 104k files and it worked.

[kevinsawicki]

Closing as fixed by #80