From 9969f8b03276254d75404b60c15d6125f0f1be79 Mon Sep 17 00:00:00 2001 From: bboure Date: Sun, 23 Oct 2022 21:13:02 +0200 Subject: [PATCH] feat(publisher-s3): Add sessionToken and change default fallback --- packages/publisher/s3/src/Config.ts | 12 ++++++++++-- packages/publisher/s3/src/PublisherS3.ts | 7 ++++--- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/packages/publisher/s3/src/Config.ts b/packages/publisher/s3/src/Config.ts index bb5fffebe9..0ff4d02c96 100644 --- a/packages/publisher/s3/src/Config.ts +++ b/packages/publisher/s3/src/Config.ts @@ -2,16 +2,24 @@ export interface PublisherS3Config { /** * Your AWS Access Key ID * - * Falls back to the AWS_ACCESS_KEY_ID environment variable if not provided + * Falls back to the the default credential provider chain if not + * provided */ accessKeyId?: string; /** * The secret for your AWS Access Key * - * Falls back to the AWS_SECRET_ACCESS_KEY environment variable if not + * Falls back to the the default credential provider chain if not * provided */ secretAccessKey?: string; + /** + * The session token for your AWS Access Key + * + * Falls back to the the default credential provider chain if not + * provided + */ + sessionToken?: string; /** * The name of the S3 bucket to upload artifacts to */ diff --git a/packages/publisher/s3/src/PublisherS3.ts b/packages/publisher/s3/src/PublisherS3.ts index 8681cc3fda..77ae127835 100644 --- a/packages/publisher/s3/src/PublisherS3.ts +++ b/packages/publisher/s3/src/PublisherS3.ts @@ -90,11 +90,12 @@ export default class PublisherS3 extends PublisherBase { } generateCredentials(): Credentials | undefined { - const accessKeyId = this.config.accessKeyId || process.env.AWS_ACCESS_KEY_ID; - const secretAccessKey = this.config.secretAccessKey || process.env.AWS_SECRET_ACCESS_KEY; + const accessKeyId = this.config.accessKeyId; + const secretAccessKey = this.config.secretAccessKey; + const sessionToken = this.config.sessionToken; if (accessKeyId && secretAccessKey) { - return { accessKeyId, secretAccessKey }; + return { accessKeyId, secretAccessKey, sessionToken }; } return undefined;