From e26de71c54fb3513e277301c91c1bada324e9a21 Mon Sep 17 00:00:00 2001 From: Mark Lee Date: Sun, 6 May 2018 16:21:41 -0700 Subject: [PATCH] fix(initializer): fix setting Electron version in.compilerc when it's x.0 (#506) * fix(initializer): fix setting Electron version in.compilerc when it's x.0 * Travis: drop the cache to see if it fixes CI --- .travis.yml | 3 --- src/init/init-npm.js | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5f39e694b3..c2ada8c236 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,9 +7,6 @@ os: dist: trusty osx_image: xcode8.3 sudo: required -cache: - directories: - - node_modules services: - docker env: diff --git a/src/init/init-npm.js b/src/init/init-npm.js index 19533da6a2..c6387f15fa 100644 --- a/src/init/init-npm.js +++ b/src/init/init-npm.js @@ -75,7 +75,8 @@ export default async (dir, lintStyle) => { const envTarget = content.env[profile]['application/javascript'].presets.find(x => x[0] === 'env'); // parseFloat strips the patch version // parseFloat('1.3.2') === 1.3 - envTarget[1].targets.electron = parseFloat(electronPrebuilt.version).toString(); + // Note: This won't work if the minor version ever gets higher than 9 + envTarget[1].targets.electron = parseFloat(electronPrebuilt.version).toFixed(1).toString(); } await fs.writeJson(path.join(dir, '.compilerc'), content, { spaces: 2 });