Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React integration not working with v6.0.0-beta.56 #2322

Closed
3 tasks done
himat opened this issue Jun 12, 2021 · 0 comments · Fixed by #2330
Closed
3 tasks done

React integration not working with v6.0.0-beta.56 #2322

himat opened this issue Jun 12, 2021 · 0 comments · Fixed by #2330
Labels

Comments

@himat
Copy link

himat commented Jun 12, 2021

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Forge Version: v6.0.0-beta.56
  • Electron Version: v13.1.2
  • Operating System: MacOS 10.14.5
  • Last Known Working Electron Forge version:: NA

Expected Behavior

I originally created a new forge boilerplate project using the webpack-typescript option which gave me v6.0.0-beta.57.
But then due to the big bug reported here will-stone/browserosaurus#408, I couldn't actually compile the project since I couldn't import electron in the renderer process.
So then I downgraded to beta.56 as suggested.
I did this by doing rm -rf node_modules/ and then changed these lines in my package.json devDependencies to be 56

@electron-forge/cli: 6.0.0-beta.56,
@electron-forge/maker-deb: 6.0.0-beta.56,
@electron-forge/maker-rpm: 6.0.0-beta.56,
@electron-forge/maker-squirrel: 6.0.0-beta.56,
@electron-forge/maker-zip: 6.0.0-beta.56,
@electron-forge/plugin-webpack: 6.0.0-beta.56,

And then I did yarn install.

Actual Behavior

The code compiles now, but for some reason when I do yarn start, the contents of index.html show up and it's not replaced by the contents of my app.tsx.
I created this new project originally by doing npx create-electron-app my-new-app --template=typescript-webpack and then I followed the instructions to add react https://www.electronforge.io/guides/framework-integration/react-with-typescript.
My react app showed up originally when I was on 57, but now not on 56.

I uploaded the repo I made here if you'd like to try it yourself: https://github.com/himat/example
It's just your basic template with the example react code added.

Alternatively, can you let me know what the latest stable version of electron forge I can use instead is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant