fix: replacing macro {napi_build_version} in binary filename #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g `binary.napi_build_versions` in package.json. Fixes: electron#554
mmaietta
changed the title
refactored rebuild helper
…_build_version-macro # Conflicts: # test/helpers/module-setup.ts # test/rebuild-yarnworkspace.ts
|
Friendly bump. @MarshallOfSound. |
MarshallOfSound
approved these changes
Apr 22, 2023
|
🎉 This PR is included in version 3.2.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: replacing macro
{napi_build_version}in binary filename by usingbinary.napi_build_versionsin package.json. Fixes: #554Added unit test for offending module:
"sqlite3": "5.1.6"Tested on mac for arm64 and x64 rebuilds
Related:
electron-userland/electron-builder#7473
Original PR credit to #1076 (I just added tests as requested)