Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid shell html creation in module folder #52

Closed
onderceylan opened this issue Oct 19, 2019 · 1 comment · Fixed by #55
Closed

Avoid shell html creation in module folder #52

onderceylan opened this issue Oct 19, 2019 · 1 comment · Fixed by #55
Assignees
@onderceylan
Labels
feature request New feature or request released

Comments

@onderceylan
Copy link
Collaborator

Currently, the library saves a shell html file on the fly to the libraries /static folder each time you execute an image generation. Although it's not a problem for most users, this design causes some issues where there are ownership problems with the installed module on users OS.

We can get over this issue by using following page navigation via puppeteer;
await page.goto(data:text/html,${html});
@onderceylan onderceylan added the feature request New feature or request label Oct 19, 2019
@onderceylan onderceylan changed the title Use data:text/html for shell html navigation Avoid shell html creation in module folder Oct 19, 2019
onderceylan added a commit that referenced this issue Oct 19, 2019
@onderceylan
feat(file): avoided saving a shell html file
9311962 
Due to issues on systems with ownership problems of the module, avoided saving a file in module
folder

#52
@onderceylan onderceylan mentioned this issue Oct 24, 2019
Merged
onderceylan added a commit that referenced this issue Oct 25, 2019
@onderceylan
feat(file): avoided saving a shell html file
b96d545 
Due to issues on systems with ownership problems of the module, avoided saving a file in module
folder

#52
onderceylan pushed a commit that referenced this issue Oct 25, 2019
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
13d8f90 
# [2.0.0](v1.3.1...v2.0.0) (2019-10-25)

### Bug Fixes

* **browser:** added error handling for chrome-launcher ([c6ed23a](c6ed23a)), closes [#50](#50)
* **package:** suppressed security warning by changing pkg v strategy ([9987e39](9987e39)), closes [#53](#53)

### Features

* **file:** avoided saving a shell html file ([b96d545](b96d545)), closes [#52](#52)
* **icon:** added optional favicon generation ([699686a](699686a)), closes [#47](#47)
* **main:** added dark mode support for iOS ([f4aca1c](f4aca1c)), closes [#51](#51)
* **pptr:** switched over puppeteer-core to avoid chromium install ([05edb2e](05edb2e)), closes [#50](#50)
* **pwa:** added single quotes option for generated HTML tags ([351a3cc](351a3cc)), closes [#49](#49)

### BREAKING CHANGES

* **main:** generateImages method from the module API now returns HTMLMeta object with the
chunks of HTML content, instead of one big HTML string
@onderceylan
Copy link
Collaborator Author

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@onderceylan onderceylan self-assigned this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onderceylan onderceylan

Labels
feature request New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.0.0 release elegantapp/pwa-asset-generator
1 participant
@onderceylan