Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Election should say "ended" if you visit it after it ends #79

Open
craigbox opened this issue Oct 17, 2022 · 3 comments
Open

Election should say "ended" if you visit it after it ends #79

craigbox opened this issue Oct 17, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@craigbox
Copy link

The election is marked "completed", so the tenses of the start/end time listed at the bottom should be "started" and "ended"

Screen Shot 2022-10-17 at 1 36 48 PM

@jberkus
Copy link
Member

jberkus commented Nov 7, 2022

I don't follow?

@jberkus jberkus closed this as completed May 10, 2023
@bannmann
Copy link

@jberkus Just stumbled over this. I think what OP meant was that in the screenshot, the last line reads:

Voting starts at 2022-10-03 UTC and ends at 2022-10-16 11:59:59 UTC.

However, the screenshot was clearly made after the election was over (as it says "Completed" below the heading). So "starts at" and "ends at" are confusing. So for completed elections, the text should change as follows:

Voting startsstarted at 2022-10-03 UTC and endsended at 2022-10-16 11:59:59 UTC.

@jberkus
Copy link
Member

jberkus commented Apr 26, 2024

Makes sense. That seems like a good small change for a new contributor, so reopening.

@jberkus jberkus reopened this Apr 26, 2024
@jberkus jberkus added enhancement New feature or request good first issue Good for newcomers labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants