Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Sort keys by time of first appearance #194

Closed
manuroe opened this issue Jun 19, 2019 · 6 comments
Closed

Reactions: Sort keys by time of first appearance #194

manuroe opened this issue Jun 19, 2019 · 6 comments

Comments

@manuroe
Copy link
Member

manuroe commented Jun 19, 2019

From riot-web created by jryans: vector-im/riot-web#9698

...instead of by vote count.

@manuroe
Copy link
Member Author

manuroe commented Jun 19, 2019

SGTM

@manuroe
Copy link
Member Author

manuroe commented Jun 19, 2019

Added an MSC comment to discuss whether the bundled reactions data will support this.

@manuroe
Copy link
Member Author

manuroe commented Jun 19, 2019

Correct. To expand a little; that user behaviour is already fairly well engrained from usage on other platforms, and it also allows early reactors (including the message sender themselves) to instigate what reactions they want to see more of— e.g. 🍾 on announcements.

That, plus the current functionality of reactions dancing around your screen as you interact with them is unexpected and pretty frustrating.

There could be an argument for sorting by number of reactions when viewing older messages, but (a) that might break the 'storytelling' aspect of choosing what order to send reactions and (b) it makes it more complicated than it needs to be— figuring out the heuristics for when to switch e.g. after an amount of time, but only on timeline load so existing reactions don't unexpectedly change sort order etc so I'd prefer to look at that as a future refinement, if at all.

@manuroe
Copy link
Member Author

manuroe commented Jun 19, 2019

I think @nadonomy's argument was that it's less surprising, allows you to build "messages" out of the emoji ordering (like 🛫🇬🇧🛬), and it means the emoji key won't move out from under you when you increment it.

Is that correct @nadonomy?

@manuroe
Copy link
Member Author

manuroe commented Jun 19, 2019

Are we certain we want this? Isn't vote count more informative?

@BillCarsonFr
Copy link
Member

Already the case in RiotX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants