Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement widget credentials request as per MSC1960 #2115

Open
jaywink opened this issue Sep 16, 2020 · 2 comments
Open

Implement widget credentials request as per MSC1960 #2115

jaywink opened this issue Sep 16, 2020 · 2 comments
Labels
A-Widgets T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@jaywink
Copy link
Member

jaywink commented Sep 16, 2020

MSC1960 defines a way for widgets to request an OpenID token, which the widget can then verify the user with. This is implemented by matrix-react-sdk and used since Element Web v1.7.6 to support authenticated Jitsi widgets.

@jaywink jaywink added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Sep 16, 2020
@theCalcaholic
Copy link

theCalcaholic commented Dec 22, 2020

FYI (and asking for confirmation of my comprehension of the issue): This also affects the sticker picker widget provided by a self-hosted dimension instance:

In web, you'd get this dialog when you use the sticker picker for the first time (per client):
image

If your click deny - or are using the android client which doesn't show the dialog above, you'll get this error in the sticker picker:
image

As I'm new to Matrix, I kindly ask to confirm whether I understand this correctly. :)
If that's the case, I'd also suggest to add the parity-with-web label

If not, I'll create a new issue.

@theCalcaholic
Copy link

I created a separate issue for my bug, since it appears to be unrelated: #2587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Widgets T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

3 participants