Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results from Threads #4387

Closed
daniellekirkwood opened this issue Nov 1, 2021 · 5 comments
Closed

Search results from Threads #4387

daniellekirkwood opened this issue Nov 1, 2021 · 5 comments
Assignees
Labels
A-Threads An issue for the Threads project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Nov 1, 2021

  • When I search for a message, return results from a Thread
  • Design (pending)
  • Unencrypted Rooms & Encrypted Rooms

Designs are here: https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=2858%3A290566

EDIT: In testing on January 20 we found that tapping on the Thread root from a search result causes the app to crash.

@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Threads An issue for the Threads project Z-ThreadsP0 Issue to be released with the Threads MVP labels Nov 1, 2021
@daniellekirkwood
Copy link
Contributor Author

@janogarcia are we expecting any changes to the way that threaded messages show up when a user searches for them? Is today's behaviour acceptable?

@janogarcia
Copy link

@daniellekirkwood Thanks for flagging this one. It seems I couldn't update the issue description, so that it points to the proper Figma frame, and forgot to ping you on that.

https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=2858%3A290566

@daniellekirkwood
Copy link
Contributor Author

Thanks, @janogarcia ! I have added the link to the description and removed your assignment :)

@daniellekirkwood
Copy link
Contributor Author

We discussed this issue in standup today and have updated the issue description to remove encrypted rooms as this is not possible.

@janogarcia
Copy link

@daniellekirkwood As a side note: It's currently only supported in Element desktop client. I think there are some ideas on supporting it on the web client, but it's far from straightforward given that everything needs to happen in the client due to encryption. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads An issue for the Threads project T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP
Projects
None yet
Development

No branches or pull requests

3 participants