Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threads: Open Thread Panel from Link #4684

Closed
daniellekirkwood opened this issue Dec 10, 2021 · 5 comments
Closed

Threads: Open Thread Panel from Link #4684

daniellekirkwood opened this issue Dec 10, 2021 · 5 comments
Assignees
Labels
A-Threads An issue for the Threads project Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 10, 2021

Your use case

  1. In timeline, copy permalink to root message
  2. Link opens timeline (not thread panel)
  3. In thread timeline, copy permalink to root message
  4. Link opens timeline (not thread panel)
@daniellekirkwood daniellekirkwood added A-Threads An issue for the Threads project Z-ThreadsP0 Issue to be released with the Threads MVP labels Dec 10, 2021
@daniellekirkwood
Copy link
Contributor Author

@janogarcia If there's no way to know whether the link was copied from the Thread view or the Timeline view it might be less disorienting for the user to see the Thread Root Message in the Timeline (instead of open the Thread).

So... Receive link > Click link > See Timeline with Thread Summary > Click Thread Summary

If we agree that is acceptable behaviour for launch ☝️ then we can close this issue with no action needed.

@ariskotsomitopoulos
Copy link
Contributor

ariskotsomitopoulos commented Dec 14, 2021

@janogarcia If there's no way to know whether the link was copied from the Thread view or the Timeline view it might be less disorienting for the user to see the Thread Root Message in the Timeline (instead of open the Thread).

So... Receive link > Click link > See Timeline with Thread Summary > Click Thread Summary

If we agree that is acceptable behaviour for launch ☝️ then we can close this issue with no action needed.

That is exactly what I thought when I implemented it in that way

@janogarcia
Copy link

janogarcia commented Dec 15, 2021

@daniellekirkwood @ariskotsomitopoulos Yeah, this was discussed before for web. There isn't much we can do here, at least until we can add support for Element-specific params to matrix.to links (e.g. a custom source param for Element matrix.to/.../?element-src=thread). Feel free to close it, Danielle.

@gsouquet Do you think such client-specific params could be added in the future (properly namespaced for a specific client, and not having a negative impact on others, as it can be safely ignored)?

@germain-gg
Copy link
Contributor

I don't think it's desirable that matrix.to links have Element specific parameters
But maybe we can open a discussion with the folks that are specifying matrix.to and see whether that's something we want to aim for or not

I'm not sold on this yet, but can see where you're coming from

@daniellekirkwood daniellekirkwood added the Z-ThreadsInternalTesting Issue found while testing Threads internally label Dec 16, 2021
@daniellekirkwood
Copy link
Contributor Author

Have created a new issue to continue the extension of this... element-hq/element-meta#402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads An issue for the Threads project Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 Issue to be released with the Threads MVP
Projects
None yet
Development

No branches or pull requests

4 participants