Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element nightly: element-desktop-nightly.desktop contains invalid value of StartupWMClass thus element is not docked properly #524

Closed
doubleloop opened this issue Jan 31, 2023 · 1 comment

Comments

@doubleloop
Copy link

doubleloop commented Jan 31, 2023

Describe the bug

$ cat /usr/share/applications/element-desktop-nightly.desktop
[Desktop Entry]
Name=Element-Nightly
Exec=/opt/Element-Nightly/element-desktop-nightly %U
Terminal=false
Type=Application
Icon=element-desktop-nightly
StartupWMClass=element
Comment=A feature-rich client for Matrix.org
MimeType=x-scheme-handler/element;
Categories=Network;InstantMessaging;Chat;

For nightly build, StartupWMClass should be element-nightly instead of element.

This for example causes duplicated element icon in gnome dock panel:
Screenshot from 2023-02-01 00-19-22

ref: https://askubuntu.com/questions/367396/what-does-the-startupwmclass-field-of-a-desktop-file-represent/367851#367851

I believe the value is taken from package.json
https://github.com/vector-im/element-desktop/blob/f54249146747873df9f0da3a9833b7f35aa1b5e4/package.json#L135

Note: also Description could reflect the value specified in:
https://github.com/vector-im/element-desktop/blob/f54249146747873df9f0da3a9833b7f35aa1b5e4/element.io/nightly/control.template#L11

@t3chguy
Copy link
Member

t3chguy commented Feb 1, 2023

Duplicate of element-hq/element-web#13780

@t3chguy t3chguy marked this as a duplicate of element-hq/element-web#13780 Feb 1, 2023
@t3chguy t3chguy closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants