Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emoji reactions should use the colourful variation-16 selector when available #3315

Open
ara4n opened this issue Jun 4, 2020 · 1 comment
Open

Emoji reactions should use the colourful variation-16 selector when available #3315

ara4n opened this issue Jun 4, 2020 · 1 comment
Labels
A-SDK A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@ara4n
Copy link
Member

ara4n commented Jun 4, 2020

For emoji in https://unicode.org/emoji/charts/emoji-variants.html, we should prefer sending the colourful variation unless we are very deliberately sending a black and white one. This is more correct than leaving it ambiguous by missing off the selector, where some platforms may assume you meant the black and white variant. See element-hq/element-web#13926.
@graue70 graue70 mentioned this issue Oct 6, 2021
Closed
@graue70
Copy link

graue70 commented Oct 6, 2021

See element-hq/element-web#19295 for an example of how this issue shows.

@pixlwave pixlwave added A-SDK A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Papercuts Visible. Impactful. Predictable to action. T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-SDK A-Timeline O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @pixlwave @graue70