Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant mimetype information #4303

Closed
bmarty opened this issue May 5, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1125
Closed

Remove redundant mimetype information #4303

bmarty opened this issue May 5, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1125

Comments

@bmarty
Copy link
Member

bmarty commented May 5, 2021

I created element-hq/element-web#17145 because the spec is not clear.

Then I created element-hq/element-android#3273 on Element Android to remove the usage of the redundant mimetype.

But it appears that those fields are expected by Element iOS. For instance the image does not appear in the timeline of those fields are missing.

What iOS should do (IMO):

  • Remove the field MXEncryptedContentFile.mimetype
  • Ensure that image or any attachment sent without this field are correctly handled in the timeline and anywhere else.

I tried to fix the problem by myself on iOS but I'm really not an efficient iOS developer :/

The Android PR is waiting for iOS to be robust with the changes it includes before being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants