Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Thread deleted state UI for when root message removed #5473

Closed
1 task
daniellekirkwood opened this issue Nov 1, 2021 · 6 comments
Closed
1 task

Create Thread deleted state UI for when root message removed #5473

daniellekirkwood opened this issue Nov 1, 2021 · 6 comments
Assignees
@ismailgulek
Labels
A-Threads Message threading to simplify the Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads

Comments

@daniellekirkwood
Copy link
Contributor

Your use case

When the root message is deleted, still allow access to the thread

Requirements

  • Making sure that a thread can still be viewed even if the root message has been deleted
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements A-Threads Message threading to simplify the Timeline Z-ThreadsP0 The first milestone for Threads labels Nov 1, 2021
@daniellekirkwood daniellekirkwood mentioned this issue Nov 1, 2021
Closed
@daniellekirkwood
Copy link
Contributor Author

Removing Jano's assignment as Designs have been added to the issue

@janogarcia janogarcia mentioned this issue Jan 5, 2022
Closed
1 task
@daniellekirkwood
Copy link
Contributor Author

This was identified as a "fail" in the testing on January 20, 2022 as there was no "message deleted" placeholder in the room timeline or thread timeline.

@daniellekirkwood daniellekirkwood added the Z-ThreadsInternalTesting Issue found while testing Threads internally label Jan 25, 2022
@janogarcia
Copy link

@daniellekirkwood Actually I logged those issues for iOS, not Android, on January 22 session:

  • The root message in the thread wont show the "Message deleted" status until the app is reopened.
  • The deleted root message and its thread summary completely disappear from the main timeline on reopening the app.

@ariskotsomitopoulos ariskotsomitopoulos mentioned this issue Jan 31, 2022
Merged
12 tasks
@daniellekirkwood
Copy link
Contributor Author

Drats. Ok, I will move this to the iOS repo

@daniellekirkwood daniellekirkwood transferred this issue from element-hq/element-android Feb 1, 2022
@janogarcia
Copy link

It was still assigned to Aris, though. I've reassigned it to Ismail. 👍

@ismailgulek
Copy link
Contributor

Closed with #5257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ismailgulek ismailgulek

Labels
A-Threads Message threading to simplify the Timeline T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally Z-ThreadsP0 The first milestone for Threads
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janogarcia @ismailgulek @ariskotsomitopoulos @daniellekirkwood