Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replies to blocked users don't make sufficiently clear why replied-to message doesn't display #883

Open
non-Jedi opened this issue May 17, 2018 · 5 comments
Open

Replies to blocked users don't make sufficiently clear why replied-to message doesn't display #883

non-Jedi opened this issue May 17, 2018 · 5 comments
Labels
A-Room O-Occasional Affects or can be seen by some users regularly or most users rarely P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@non-Jedi
Copy link

non-Jedi commented May 17, 2018 •
edited
Loading

Description

If you block a user and then later someone replies to them, you get this very unhelpful thing:

huh_replies

Steps to reproduce

see above

Version information

  • Platform: web

For the web app:

  • Browser: qutebrowser v1.2.1 (qtwebengine)
  • OS: Void Linux glibc 64bit
  • URL: riot.im/develop
@t3chguy
Copy link
Member

t3chguy commented May 17, 2018

Not a test case I had considered. Thanks for the bug report

@t3chguy
Copy link
Member

t3chguy commented May 19, 2018 •
edited
Loading

so turns out this is a Synapse thing:
Synapse on the Context/Events API will return a 403: "M_FORBIDDEN" for that event, though strangely not for events the ignored user said before you ignored them.

@t3chguy
Copy link
Member

t3chguy commented May 19, 2018

So this is because the context codepath reaches https://github.com/matrix-org/synapse/blob/18e3a16e8b2303e6b638f679b5b8533e329cbe7a/synapse/visibility.py#L74-L84 which I'd say it shouldn't

@lampholder lampholder mentioned this issue May 30, 2018
Open
@lampholder lampholder added T-Defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 30, 2018
@turt2live
Copy link
Member

Related: element-hq/element-web#6690

@t3chguy
Copy link
Member

t3chguy commented Dec 22, 2022

Moving to element-meta as it will affect all Elements once the mobile clients render replies rather than the fallbacks.

@t3chguy t3chguy transferred this issue from element-hq/element-web Dec 22, 2022
@pmaier1 pmaier1 added T-Enhancement O-Occasional Affects or can be seen by some users regularly or most users rarely P3 A-Room and removed T-Defect P2 labels Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room O-Occasional Affects or can be seen by some users regularly or most users rarely P3 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@turt2live @lampholder @t3chguy @non-Jedi @pmaier1