Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reply fallback gets stripped upon edit #10220

Closed
bwindels opened this issue Jul 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3192
Closed

reply fallback gets stripped upon edit #10220

bwindels opened this issue Jul 1, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3192
Assignees
@bwindels
Labels
A-Aggregations A-Message-Editing P1 T-Defect

Comments

@bwindels
Copy link
Contributor

bwindels commented Jul 1, 2019 •
edited
Loading

When parsing an event to edit it, the mx-reply tag gets filter out. When submitting the edit, the mx-reply doesn't get reinserted though.
@bwindels
Copy link
Contributor Author

bwindels commented Jul 1, 2019 •
edited
Loading

we should do 3 things:

  • if the message we're editing is a reply, serialize it as an html message, as required by the spec.
  • we should copy the mx-reply tag from the original event into the formatted_body.
  • we should copy the first > ... line into the body (probably only if it starts with a >).

@bwindels bwindels mentioned this issue Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Aggregations A-Message-Editing P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve reply fallback on edit matrix-org/matrix-react-sdk
2 participants
@bwindels @jryans