Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using React Portals (React 16) #10697

Open
t3chguy opened this issue Aug 30, 2019 · 1 comment
Open

Start using React Portals (React 16) #10697

t3chguy opened this issue Aug 30, 2019 · 1 comment
Labels
T-Task Tasks for the team like planning

Comments

@t3chguy
Copy link
Member

t3chguy commented Aug 30, 2019

So external libraries better support our Modals due to proper conventions, it simplifies Modal.js and cleans up DOM debugging in React Dev Tools

https://reactjs.org/docs/portals.html
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Aug 30, 2019
@t3chguy t3chguy changed the title Start using React Portals Start using React Portals (React 16) Aug 30, 2019
@t3chguy t3chguy mentioned this issue Aug 30, 2019
Closed
@t3chguy t3chguy self-assigned this Sep 18, 2019
@t3chguy
Copy link
Member Author

t3chguy commented Dec 16, 2019 •
edited
Loading

The way we use Modals is primarily async so using Portals here is trickier, we now use Portals for Context Menus though which is a big win.
The next step here would be to mount Modals within the React tree but somewhere high up, so that they don't get the context of the caller but maybe that of LoggedInView at the least. This can be done using contexts + portals.

@t3chguy t3chguy removed their assignment Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t3chguy