Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply fallback is included in edited message m.new_content #11129

Closed
tulir opened this issue Oct 12, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3551
Closed

Reply fallback is included in edited message m.new_content #11129

tulir opened this issue Oct 12, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3551
Labels

Comments

@tulir
Copy link
Contributor

tulir commented Oct 12, 2019

Didn't find an issue for this yet and nobody has done it. Bad behavior was introduced in matrix-org/matrix-react-sdk#3192.

As per the aggregation proposal:

The edited reply should ditch the fallback representation of the reply itself however from m.new_content (specifically the <mx-reply> tag in the HTML, and the chevron prefixed text in the plaintext which we don't know whether to parse as we don't know whether this is a reply or not), as we can assume that any client which can handle edits can also display replies natively.

XXX: make Riot do this

@t3chguy
Copy link
Member

t3chguy commented Oct 14, 2019

MSC1849 is still in review, so am not 100% whether this can land

@tulir
Copy link
Contributor Author

tulir commented Oct 14, 2019

Why did reactions and edits land then 🤔

That quote is from the latest version of MSC1849. Other clients can not safely remove the reply fallback in the edit m.new_content, so it must not be included. My comment in the MSC1849 extension (that was already merged) goes into more detail: matrix-org/matrix-spec-proposals#2154 (comment)

@t3chguy
Copy link
Member

t3chguy commented Oct 14, 2019

Let me rephrase, I know not enough as to whether it can land or not :D
but code-wise it is sane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants