Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EmojiPicker accessible #11284

Closed
1 of 2 tasks
t3chguy opened this issue Nov 1, 2019 · 1 comment
Closed
1 of 2 tasks

Make EmojiPicker accessible #11284

t3chguy opened this issue Nov 1, 2019 · 1 comment
Assignees
@t3chguy
Labels
A11y A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist

Comments

@t3chguy
Copy link
Member

t3chguy commented Nov 1, 2019 •
edited
Loading

From in-review PRs you can now get to it, and get dumped into the search box, you can access the "tab" buttons but cannot access the emoji list, tab from the search input acts as if it was the last tabstop in the document causing you to go into browser controls.

  • Use aria tabs instead of "tab" buttons with no real semantics
  • Fix tab stops around the emoji complete, using a single tab stop for the tabs, one for search, one for resultant emojis and one for quick reactions, in each of those, arrow keys should act as navigation within that widget
@t3chguy t3chguy self-assigned this Dec 16, 2019
@t3chguy t3chguy mentioned this issue Dec 16, 2019
Closed
@t3chguy t3chguy mentioned this issue May 25, 2020
Merged
@jryans jryans added A11y and removed I18n labels Mar 5, 2021
@ShadowJonathan ShadowJonathan mentioned this issue Sep 1, 2021
Closed
@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P1 labels Oct 14, 2022
@t3chguy
Copy link
Member Author

t3chguy commented Apr 14, 2023

Closing in favour of #17189

@t3chguy t3chguy closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A11y A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First draft of EmojiPicker keyboard and screen reader accessibility matrix-org/matrix-react-sdk
3 participants
@jryans @MadLittleMods @t3chguy