Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context links give a 404 on federated rooms #1230

Closed
ara4n opened this issue Mar 19, 2016 · 7 comments · Fixed by matrix-org/matrix-react-sdk#2250
Closed

Context links give a 404 on federated rooms #1230

ara4n opened this issue Mar 19, 2016 · 7 comments · Fixed by matrix-org/matrix-react-sdk#2250
Assignees
Labels
A-Matrix.to A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Backend

Comments

@ara4n
Copy link
Member

ara4n commented Mar 19, 2016

I clicked on https://vector.im/develop/#/room/#purple:matrix.org/$1451504230525382RHTLB:matrix.org in Safari, which was logged into a non-guest account not joined to #purple:matrix.org already. It showed me a 'join this room' prompt; i clicked join; it got stuck on an infinite spinner in the RoomPreviewBar. Switching away from the room and back again fixed it, but then I had to re-load the URL to actually get the context link up.

@ara4n ara4n added T-Defect T-Task Tasks for the team like planning P1 labels Mar 19, 2016
@ara4n ara4n added this to the v2 - Public Preview milestone Mar 19, 2016
@ara4n ara4n added S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed T-Task Tasks for the team like planning labels Mar 19, 2016
@ara4n
Copy link
Member Author

ara4n commented Mar 19, 2016

one other datapoint: the account in question was on arasphere.net rather than matrix.org.

@richvdh
Copy link
Member

richvdh commented Mar 21, 2016

This is a combination of #979, together with the fact that synapse does not make requests over federation when it receives a /context request.

@erikjohnston: any feeling for how easy it will be to fix the latter?

@richvdh richvdh changed the title Context links fail when you need to join a room Context links give a 404 on federated rooms Mar 21, 2016
@richvdh richvdh assigned erikjohnston and unassigned richvdh Mar 21, 2016
@richvdh
Copy link
Member

richvdh commented May 18, 2016

see also #1532

@ara4n
Copy link
Member Author

ara4n commented Sep 12, 2018

i've finally filed a synapse issue for this one.

@ara4n
Copy link
Member Author

ara4n commented Sep 12, 2018

Meanwhile #2925 also gets in the way of permalinks working.

@turt2live
Copy link
Member

matrix-org/matrix-react-sdk#2250 fixes this, although only to the point of being able to join. Due to the synapse bug users will be hit with "Failed to load the timeline position" until their server backpaginates enough of the history.

@turt2live
Copy link
Member

Closing this as matrix-org/matrix-react-sdk#2250 addresses the Riot part of the problem. To actually fix the remainder of the issue, matrix-org/synapse#3848 should be fixed. Closing as the remainder is a synapse problem - please reopen if there's disagreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Matrix.to A-Timeline P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants