Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require confirmation to start a direct message from right panel #16300

Closed
aaronraimist opened this issue Jan 28, 2021 · 10 comments
Closed

Require confirmation to start a direct message from right panel #16300

aaronraimist opened this issue Jan 28, 2021 · 10 comments

Comments

@aaronraimist
Copy link
Collaborator

Is your suggestion related to a problem? Please describe.
I find myself accidentally creating a DM with someone every week or two. I think what is happening is I expect the Mention button to be first in the list but Direct Message is the first option listed so if I am rushing then I'll accidentally click that instead.

Describe the solution you'd like
I would like Element to make me confirm I want to start a DM by clicking a button in a dialog box. In addition to preventing accidental DMs this dialog box could also have a text field for adding an invite reason matrix-org/matrix-spec-proposals#2367.

Describe alternatives you've considered
Another solution to fix my particular problem would be to reorder the list of options in the right panel to put Mention first but it probably doesn't make sense to break the muscle memory of everyone else who was able to properly learn the order.

Additional context
Screen Shot

@2580ayush2580
Copy link

shall I work on this? I
Can you please describe more about what solution would you like?

@aaronraimist
Copy link
Collaborator Author

Yes you can work on it if you would like to. I would like a dialog box to show up when you click on "Direct message" in the right panel. I imagine it would look similar to the dialog box that shows up when you remove a message.

screenshot

but instead would say something like "Are you sure you wish to start a direct message with USER? You can optionally provide a reason that will be shown to the other user before they accept the invite."

The code for that dialog is here if you want to use that for inspiration https://github.com/matrix-org/matrix-react-sdk/blob/develop/src/components/views/dialogs/ConfirmRedactDialog.js

@2580ayush2580
Copy link

okay sure!
I am working on this

@jryans
Copy link
Collaborator

jryans commented Feb 5, 2021

As mentioned on the first PR attempted here, @nadonomy would like to see a different approach which avoids adding friction to the DM process by improving the styling of the panel to avoid accidental actions.

@SimonBrandner
Copy link
Contributor

Discord has this:

Screenshot_20210205_162122

Maybe we could use something similar and maybe use the invite reason instead of the message

@nadonomy
Copy link
Contributor

nadonomy commented Feb 5, 2021

@SimonBrandner that's an interesting suggestion. I wonder if it opens up pandoras box on cross-platform users expecting the same functionality on mobile, and also if there might be any implementation implications related to Canonical DMs.

@SimonBrandner
Copy link
Contributor

Hmmm, the more I think about this, I think it would be better not to have an invite reason for Canonical DMs and have the UI work in a similar way to Discord.

No matter what we end up doing with the invite reason I think the button that starts the DM should differentiate itself from the rest of the things in the panel. I think this way the chance that the user clicks it by accident is smaller. Discord's solution is even better for this because the user needs to click the text box, type the message and press enter.

Maybe something like this?

Screenshot_20210205_210532

@aaronraimist
Copy link
Collaborator Author

screenshot

Whatever happened to this UI where DMs were a separate section? I guess it was removed in preparation for canonical DMs or something but I liked it being a separate section showing any DMs you already had. A big Direct Message button could go into that section.

@Half-Shot
Copy link
Member

Pleeease can we look at something for this. I've had to apologise a lot for creating spam rooms because Element doesn't treat some of my legacy rooms as DMs, nor rooms with 3 people. It's actually causing me to avoid using the button entirely because the behaviour is non-deterministic.

@aaronraimist
Copy link
Collaborator Author

Duplicate of #14736

@aaronraimist aaronraimist marked this as a duplicate of #14736 May 20, 2022
@aaronraimist aaronraimist closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants