Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grey dot on space icon looks like a visual bug #16994

Closed
ara4n opened this issue Apr 19, 2021 · 8 comments · Fixed by matrix-org/matrix-react-sdk#5983
Closed

Grey dot on space icon looks like a visual bug #16994

ara4n opened this issue Apr 19, 2021 · 8 comments · Fixed by matrix-org/matrix-react-sdk#5983
Assignees
Labels
A-Notifications A-Spaces Spaces, groups, communities T-Defect X-Needs-Product More input needed from the Product team

Comments

@ara4n
Copy link
Member

ara4n commented Apr 19, 2021

Plus, what does it mean?

Screenshot 2021-04-19 at 09 42 05

@ara4n ara4n added the T-Defect label Apr 19, 2021
@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2021

that one of your rooms has a grey dot on it

e.g
image

@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2021

Related #16836

@t3chguy t3chguy added A-Notifications A-Spaces Spaces, groups, communities X-Needs-Product More input needed from the Product team labels Apr 19, 2021
@t3chguy t3chguy self-assigned this May 4, 2021
@niquewoodhouse
Copy link

Using a 3px border of groupFilterPanel-bg-color (or whatever the space panel uses for bg. Would only work on notifications in space panel, obviously.

image

image

@t3chguy not sure if we need to do the same/similar to other notifications for sake of simplicity. Using a 2px border instead here because the other notification dots/badges are much bigger already.

image
image

image
image

@t3chguy
Copy link
Member

t3chguy commented May 5, 2021

We first need product to decide if showing grey dots (unread rooms you likely don't care about, e.g name changes) on space panel are something we even want.

Just like we don't expose the grey dot on the app icon, as its too noisy;
image

@nadonomy
Copy link
Contributor

nadonomy commented May 6, 2021

@t3chguy @niquewoodhouse I've just been tracing through some pros & cons of the grey dots, the headlines I'm arriving at are:

Without the dot

  • Pro: Reduces noise for users in high traffic rooms/spaces
  • Con: Don't know when there's activity in Spaces, forcing a behaviour of needing to manually hunt

With the dot

  • Pro: Know when there's activity in rooms or spaces
  • Pro: Leverages affordance from other platforms
  • Con: Visual noise for users in high traffic rooms/spaces

My sense is the 'high traffic' users will develop blindness to the dots anyway, leaving the utility for everyone else— so I think we should go ahead with the dot to learn more in the beta.

(unread rooms you likely don't care about, e.g name changes)

@t3chguy on this— iirc metadata related events (rather than messages) like name changes don't inform the room list decoration, am I misremembering? My assumption was that whatever logic we're using there would be mirrored here.

@t3chguy
Copy link
Member

t3chguy commented May 6, 2021

iirc metadata related events (rather than messages) like name changes don't inform the room list decoration, am I misremembering?

Yes, they do - anything unread will trigger a grey dot on a room list tile.

My assumption was that whatever logic we're using there would be mirrored here.

Sure but we already use different logic for the app tile so this feels a bit strange
I think #16836 tracks it sufficiently, will add a border to the dots to visually repair them.

@nadonomy
Copy link
Contributor

nadonomy commented May 6, 2021

Yes, they do - anything unread will trigger a grey dot on a room list tile.

Gotcha. I thought we whitelisted specific events (messages/media uploads/calls/etc) to inform decoration but I must've been misremembering.

will add a border to the dots to visually repair them.

For this issue/the beta staying the course on visual tweaks and not opening pandoras box on decoration logic sounds good to me!

@t3chguy
Copy link
Member

t3chguy commented May 6, 2021

Gotcha. I thought we whitelisted specific events (messages/media uploads/calls/etc) to inform decoration but I must've been misremembering.

That was the plan, but it was part of FTUE Notifications which stalled out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Spaces Spaces, groups, communities T-Defect X-Needs-Product More input needed from the Product team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants