-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grey dot on space icon looks like a visual bug #16994
Comments
Related #16836 |
Using a 3px border of groupFilterPanel-bg-color (or whatever the space panel uses for bg. Would only work on notifications in space panel, obviously. @t3chguy not sure if we need to do the same/similar to other notifications for sake of simplicity. Using a 2px border instead here because the other notification dots/badges are much bigger already. |
@t3chguy @niquewoodhouse I've just been tracing through some pros & cons of the grey dots, the headlines I'm arriving at are: Without the dot
With the dot
My sense is the 'high traffic' users will develop blindness to the dots anyway, leaving the utility for everyone else— so I think we should go ahead with the dot to learn more in the beta.
@t3chguy on this— iirc metadata related events (rather than messages) like name changes don't inform the room list decoration, am I misremembering? My assumption was that whatever logic we're using there would be mirrored here. |
Yes, they do - anything unread will trigger a grey dot on a room list tile.
Sure but we already use different logic for the app tile so this feels a bit strange |
Gotcha. I thought we whitelisted specific events (messages/media uploads/calls/etc) to inform decoration but I must've been misremembering.
For this issue/the beta staying the course on visual tweaks and not opening pandoras box on decoration logic sounds good to me! |
That was the plan, but it was part of FTUE Notifications which stalled out. |
Plus, what does it mean?
The text was updated successfully, but these errors were encountered: