Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2EE spectacularly fails to recover after running out of OTKs #17578

Open
ara4n opened this issue Jun 7, 2021 · 3 comments
Open

E2EE spectacularly fails to recover after running out of OTKs #17578

ara4n opened this issue Jun 7, 2021 · 3 comments
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto

Comments

@ara4n
Copy link
Member

ara4n commented Jun 7, 2021

I'm assuming that after being offline for a week, eleweb ran out of OTKs. However, since coming back online, i'm still getting UISIs from everyone - it looks like they've given up trying to reestablish new Olm sessions.

Meanwhile, surely we should be providing fallback keys to prevent this failure mode?

@ara4n ara4n added the T-Defect label Jun 7, 2021
@SimonBrandner SimonBrandner added A-E2EE S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jun 7, 2021
@jryans jryans added the P1 label Jun 9, 2021
@jryans
Copy link
Collaborator

jryans commented Jun 11, 2021

I have confirmed that at least for two web users, we do successfully claim fallback keys when OTKs run out, and the target user is able to read those messages (without trying a room key request), so the core functionality of fallback keys is working here.

This may require deeper analysis by the crypto team down the road.

@ara4n
Copy link
Member Author

ara4n commented Jun 11, 2021

any idea whether Element Mobile handles sending to an OTK-exhausted Element Web well? As this might explain my symptoms.

@ara4n
Copy link
Member Author

ara4n commented Jul 12, 2021

@lampholder and @Philip-Roy confirm seeing this recently too - i've asked tom to rageshake given his is in progress right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto
Projects
None yet
Development

No branches or pull requests

5 participants