Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Toast changed colour on dark theme #18396

Closed
turt2live opened this issue Aug 4, 2021 · 4 comments
Closed

Update Toast changed colour on dark theme #18396

turt2live opened this issue Aug 4, 2021 · 4 comments
Assignees
@SimonBrandner
Labels
A-Appearance A-Toast X-Release-Blocker

Comments

@turt2live
Copy link
Member

@SimonBrandner
Copy link
Contributor

This was an intentional decision by @gaelledel and me in matrix-org/matrix-react-sdk#6470. This matches the current design https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=2241%3A50.

@turt2live, is this issue just checking if this is intentional or would you like it to be reverted?

@SimonBrandner SimonBrandner added A-Toast X-Needs-Info This issue is blocked awaiting information from the reporter A-Appearance labels Aug 5, 2021
@SimonBrandner SimonBrandner mentioned this issue Aug 12, 2021
Closed
@gaelledel
Copy link

@SimonBrandner We need to update to the "system" shade for both themes https://www.figma.com/file/X4XTH9iS2KGJ2wFKDqkyed/Compound?node-id=2241%3A50

@SimonBrandner SimonBrandner self-assigned this Aug 12, 2021
@SimonBrandner SimonBrandner removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Aug 12, 2021
@novocaine
Copy link
Contributor

Fixed by matrix-org/matrix-react-sdk#6606

@SimonBrandner
Copy link
Contributor

Fixed by matrix-org/matrix-react-sdk#6606

Ah, thanks, totally forgot to do that :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Appearance A-Toast X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@novocaine @turt2live @SimonBrandner @gaelledel