Lightbox doesn't handle hi-dpi images (and shows retina images at 2x physical size rather than 1x physical size)

[ara4n]

No description provided.

[SimonBrandner]

The current behaviour was a conscious decision, see #17049

[SimonBrandner]

Related: #17114

[ara4n]

The current behaviour was a conscious decision, see #17049

...but #17049 was asking for the same behaviour that i'm asking for here: if the image is small, it starts at 100%, and you would click to zoom. If it's big, it's shrunk to fit on the page, and you click to zoom.

So the current behaviour may be a conscious decision, but i'm not sure it's the right one?

matrix-org/matrix-react-sdk#5916 sounds promising in terms of specifying dynamic zoom settings - can we change it so that we display at 100% by default (unless the image needs to be shrunk to fit on the page?)

[robintown]

I'm confused - isn't it already the current behavior to show images at 100% zoom by default, shrinking to fit the screen if necessary? For example, for an image that is smaller than the lightbox at 100% zoom, this is what I see: (namely, 100% zoom)

[SimonBrandner]

I'm confused - isn't it already the current behavior to show images at 100% zoom by default, shrinking to fit the screen if necessary?

Yes, it should be

[ara4n]

Ah - the actual bug may be that the lightbox doesn't respect hi-dpi images (but the timeline does). So if you take a screenshot on macOS (e.g. the PNG below), the timeline renders it correctly at 2x dpi, but both the upload preview and then the lightbox view it at 1x dpi (i.e. twice as physically large as it should be).

given 99% of the images i post on EW are screenshots, i assumed it was doing it for everything.

(n.b. github correctly handles hi-dpi images, and shows the image here at the right physical size).

[ara4n]

see also #9530