Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta dot animation breaking fonts subpixel antialiasing on Windows in Chrome #18564

Closed
Palid opened this issue Aug 16, 2021 · 2 comments
Closed
Labels
A11y A-User-Menu The top left main menu with the user's name and avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Palid
Copy link
Contributor

Palid commented Aug 16, 2021

It seems that the animation mx_Beta_bluePulse used in class mx_BetaDot is making an enormous layout trashing and is a second source of fonts not being correctly subpixel antialiased on Windows. The main source so far is the background-blur on left panel, which is being taken care of here: matrix-org/matrix-react-sdk#6262

To reproduce proper behavior comment out class .mx_BetaDot in res/css/views/beta/_BetaCard.scss and remove all backdrop-filter references from our css codebase.
The other way to verify if rendering is proper is to look for layer borders checkbox which is accessible via Chrome Devtools cog menu (Rendering). Screenshots below:

Valid fonts rendering (properly antialiased) will have this kind of layer borders:
CleanShot 2021-08-16 at 11 58 40

Invalid fonts rendering layer borders (it's super easy to just look at the bottom-right corner with icons):
CleanShot 2021-08-16 at 11 59 40

The fonts rendering is irreproducible on anywhere except Windows and Chrome/Chromium, yet the layers part should be easily reproducible on any system using Chrome.

Related: matrix-org/matrix-react-sdk#6262 (gets rid of background-blur and replaces it with canvas, which doesn't trash the layout)
Related: element-hq/element-desktop#682

@Palid Palid added A-User-Menu The top left main menu with the user's name and avatar A11y O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Aug 16, 2021
@Palid
Copy link
Contributor Author

Palid commented Aug 25, 2021

Revisit in a week, this is either already solved, or will be automatically closed after we release the version without beta dot.

@Palid
Copy link
Contributor Author

Palid commented Sep 27, 2021

Seems to be sorted out by the DOM rework.

@Palid Palid closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-User-Menu The top left main menu with the user's name and avatar O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

1 participant