Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VoiceRecordComposerTile overlay MessageComposer in narrow mode #18806

Open
germain-gg opened this issue Aug 27, 2021 · 8 comments
Open

Make VoiceRecordComposerTile overlay MessageComposer in narrow mode #18806

germain-gg opened this issue Aug 27, 2021 · 8 comments
Labels
A-Composer A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@germain-gg
Copy link
Contributor

Your use case

Make the VoiceRecordComposerTile overlay MessageComposer in narrow mode.

As part of #18533 we have hidden the voice recording button to pursue more important value point regarding to threading

Have you considered any alternatives?

No response

Additional context

Screen Shot 2021-08-27 at 09 47 49

Some visual exploration. The waveform width would be responsive

@germain-gg germain-gg added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement A-Composer A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 27, 2021
@masterflitzer
Copy link

why exactly was the voice recording button hidden? it's not quite clear to me how this is related to threading...

@t3chguy
Copy link
Member

t3chguy commented Mar 2, 2022

@masterflitzer because the component falls apart at narrow widths, threads are always narrow yet will want voice recording so the threads team will handle the fix.

@masterflitzer
Copy link

masterflitzer commented Mar 2, 2022

@t3chguy but this shouldn't affect normal UI, also it should be responsive to window size no?
so when I have my window in fullscreen I should be able to see the icons because there is enough space...
also I don't even see an option for threads, still the voice icon got removed so I need more time to access that functionality without any benefit

@t3chguy
Copy link
Member

t3chguy commented Mar 3, 2022

@masterflitzer this issue is about the voice message button being entirely missing in narrow mode

image

See #20887 (comment)

@masterflitzer
Copy link

thx for pointing me to the right issue, could you explain how i get into the narrow mode you are showing?

@t3chguy
Copy link
Member

t3chguy commented Mar 3, 2022

The one I showed is from threads, but just making your window narrow or your left&right panels wide (so that the timeline is less than 500px wide) will put you in narrow mode.

@masterflitzer
Copy link

ok the voice button is missing for me too, it happens as soon the attachment button gets hidden, maybe they forgot to add the voice button to the hidden menu when switching to narrow mode or there is a limit of 4 items that needs to be lifted

@t3chguy
Copy link
Member

t3chguy commented Mar 3, 2022

ok the voice button is missing for me too, it happens as soon the attachment button gets hidden, maybe they forgot to add the voice button to the hidden menu when switching to narrow mode or there is a limit of 4 items that needs to be lifted

No. Its this entire issue, the UX for recording a voice message doesn't fit in such a narrow view, hence it was removed in that case and this issue was created to make it responsive and bring it back.

As part of #18533 we have hidden the voice recording button to pursue more important value point regarding to threading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Voice-Messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants