-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make VoiceRecordComposerTile overlay MessageComposer in narrow mode #18806
Comments
why exactly was the voice recording button hidden? it's not quite clear to me how this is related to threading... |
@masterflitzer because the component falls apart at narrow widths, threads are always narrow yet will want voice recording so the threads team will handle the fix. |
@t3chguy but this shouldn't affect normal UI, also it should be responsive to window size no? |
@masterflitzer this issue is about the voice message button being entirely missing in narrow mode See #20887 (comment) |
thx for pointing me to the right issue, could you explain how i get into the narrow mode you are showing? |
The one I showed is from threads, but just making your window narrow or your left&right panels wide (so that the timeline is less than 500px wide) will put you in narrow mode. |
ok the voice button is missing for me too, it happens as soon the attachment button gets hidden, maybe they forgot to add the voice button to the hidden menu when switching to narrow mode or there is a limit of 4 items that needs to be lifted |
No. Its this entire issue, the UX for recording a voice message doesn't fit in such a narrow view, hence it was removed in that case and this issue was created to make it responsive and bring it back.
|
Your use case
Make the
VoiceRecordComposerTile
overlayMessageComposer
in narrow mode.As part of #18533 we have hidden the voice recording button to pursue more important value point regarding to threading
Have you considered any alternatives?
No response
Additional context
Some visual exploration. The waveform width would be responsive
The text was updated successfully, but these errors were encountered: