Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the E2EE device verification and keys requesting flow #18881

Open
Palid opened this issue Sep 3, 2021 · 1 comment
Open

Improve the E2EE device verification and keys requesting flow #18881

Palid opened this issue Sep 3, 2021 · 1 comment
Assignees
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design X-Needs-Investigation

Comments

@Palid
Copy link
Contributor

Palid commented Sep 3, 2021

Currently the flow to request keys to unencrypt old messages on a new device is extremely confusing for a lot of users. We don't provide enough data to the users that they will be able to unecrypt only messages from cross-verified sessions, and not from all the verified sessions.

There's also the case where users click "request keys" link under a message, but that doesn't do anything because this session is not cross-verified with a session that has those keys.

The general idea about this issue is to:

  • Improve copy for those actions to properly notify user that they may not be able to unencrypt messages if they aren't cross-verified with proper session
  • Add some big, error modal window that your sessions are not properly verified, as of above, and that the keys request has failed

Probably adding a way to see which sessions are cross-verified in the sessions list would be quite useful too, but if I remember correctly we don't exactly have a way of knowing this?

Related: #18652

@Palid Palid added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 3, 2021
@Palid Palid changed the title Improve the E2E device verification and keys requesting flow Improve the E2EE device verification and keys requesting flow Sep 3, 2021
@americanrefugee
Copy link

Hello! This seems related to Issue #9544, in which case perhaps that will fix things. If not, then we can pick this back up whenever it makes sense. Either way I'm happy to support on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement X-Needs-Design X-Needs-Investigation
Projects
None yet
Development

No branches or pull requests

4 participants