Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix root event look in room timeline for message bubbles #18986

Closed
germain-gg opened this issue Sep 10, 2021 · 2 comments
Closed

Fix root event look in room timeline for message bubbles #18986

germain-gg opened this issue Sep 10, 2021 · 2 comments
Assignees
@janogarcia @Palid
Labels
A-Message-Bubbles A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Milestone
App Team 1.9.4

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Switch on message bubbles in labs
  2. Switch on threaded messages
  3. Go on a room with a thread

What happened?

What did you expect?

Not that...

Screen Shot 2021-09-10 at 17 03 16

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Have you submitted a rageshake?

No
@germain-gg germain-gg added T-Defect S-Tolerable Low/no impact on users X-Needs-Design A-Message-Bubbles O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Threads labels Sep 10, 2021
@germain-gg
Copy link
Contributor Author

Removing needs design as we're not going to optimise for that use case, but we'll make sure it does not look broken

@germain-gg germain-gg mentioned this issue Oct 15, 2021
Closed
@germain-gg germain-gg added this to the App Team 1.9.4 milestone Oct 21, 2021
@germain-gg
Copy link
Contributor Author

Fixed by matrix-org/matrix-react-sdk#6971 and matrix-org/matrix-react-sdk#6979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janogarcia janogarcia

@Palid Palid

Labels
A-Message-Bubbles A-Threads O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
App Team 1.9.4
Development

No branches or pull requests
4 participants
@janogarcia @germain-gg @Palid @daniellekirkwood