Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically replace plain text emoji duplicates last character #19073

Closed
clokep opened this issue Sep 16, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6823
Closed

Automatically replace plain text emoji duplicates last character #19073

clokep opened this issue Sep 16, 2021 · 3 comments · Fixed by matrix-org/matrix-react-sdk#6823
Assignees
@SimonBrandner
Labels
A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@clokep
Copy link

clokep commented Sep 16, 2021

Steps to reproduce

  1. Enable "Automatically replace plain text Emoji"
  2. Click into the composter
  3. Type :-D<space>

What happened?

What did you expect?

I expected my composer to be 😀<space>

What happened?

My composer is 😀D<space>

Operating system

macOS

Application version

Element Nightly version: 2021091601 Olm version: 3.2.3

How did you install the app?

I don't remember

Homeserver

matrix.org

Have you submitted a rageshake?

No
@clokep
Copy link
Author

clokep commented Sep 16, 2021 •
edited
Loading

This might be a regression from matrix-org/matrix-react-sdk#6784 as that shows typing :D replacing properly (which I've confirmed does work), it's just when you add a nose (:-D) that things break.

@SimonBrandner SimonBrandner self-assigned this Sep 16, 2021
@SimonBrandner SimonBrandner added A-Emoji S-Minor Impairs non-critical functionality or suitable workarounds exist X-Regression X-Release-Blocker O-Occasional Affects or can be seen by some users regularly or most users rarely labels Sep 16, 2021
@SimonBrandner SimonBrandner mentioned this issue Sep 16, 2021
Merged
@clokep
Copy link
Author

clokep commented Sep 20, 2021

Thanks for the quick fix! 🎉

@SimonBrandner
Copy link
Contributor

Thanks for the quick fix! tada

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonBrandner SimonBrandner

Labels
A-Emoji O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
2 participants
@clokep @SimonBrandner