Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redaction events are not partitioned correctly in threads #19229

Closed
germain-gg opened this issue Sep 30, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6888
Closed

Redaction events are not partitioned correctly in threads #19229

germain-gg opened this issue Sep 30, 2021 · 0 comments · Fixed by matrix-org/matrix-react-sdk#6888
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Enable threads
  2. Edit an event that is part of a thread

(Possible to test once matrix-org/matrix-react-sdk#6877 lands)

What happened?

What did you expect?

For the message to be edited

What happened?

The redaction event was received properly, however the sync.ts::partitionThreadedEvents method did not recognise that this should be sent a thread's way. Therefore it ended up in the main timeline and the message did not appear edited.

In the case of editing a root event, the event should be sent both in the main timeline and in the thread's timeline

Operating system

No response

Browser information

No response

URL for webapp

No response

Homeserver

No response

Have you submitted a rageshake?

No
@germain-gg germain-gg added T-Defect A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Sep 30, 2021
@germain-gg germain-gg self-assigned this Sep 30, 2021
This was referenced Sep 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass replacingEventId for edits to appear in thread's view matrix-org/matrix-react-sdk
1 participant
@germain-gg