Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on the thread info should highlight the previewed message #19404

Closed
Tracked by #18958
Palid opened this issue Oct 15, 2021 · 1 comment
Closed
Tracked by #18958

Clicking on the thread info should highlight the previewed message #19404

Palid opened this issue Oct 15, 2021 · 1 comment
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning

Comments

@Palid
Copy link
Contributor

Palid commented Oct 15, 2021 •
edited
Loading

When clicking on the thread info the message in main timeline should be properly highlighted (.mx_ThreadInfo-active should be added to .mx_ThreadInfo).
Currently EventTile has no way of knowing what RightPanel is open and has no knowledge about it's data. We need to move around the RightPanel phase state somewhere higher (RoomContext?) so that we can access the necessary data without adding yet another unsynced state property to EventTile.
@Palid Palid mentioned this issue Oct 15, 2021
Closed
5 tasks
@Palid Palid changed the title Clicking on the thread info should open the thread view sidebar and highlight the previewed message Clicking on the thread info should highlight the previewed message Oct 15, 2021
@Palid Palid added A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning labels Oct 15, 2021
This was referenced Oct 15, 2021
Merged
Closed
@germain-gg
Copy link
Contributor

Closing as duplicate of #18954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @Palid @daniellekirkwood