Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click on a resizer opens context menu and triggers resizer #20105

Closed
jaller94 opened this issue Dec 8, 2021 · 5 comments
Closed

Right click on a resizer opens context menu and triggers resizer #20105

jaller94 opened this issue Dec 8, 2021 · 5 comments
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@jaller94
Copy link
Contributor

jaller94 commented Dec 8, 2021

Your use case

Peek 2021-12-08 14-49

What would you like to do?

When right clicking on a resizer, it shouldn't trigger both the context menu and the resizer.

Why would you like to do it?

In most cases I wanted just the context menu and was confused when the resizer started following my cursor.

How would you like to achieve it?

Alternatives:

  1. Don't start the resizer's behaviour on any click but a main click. This is what I expect in a webapp.
  2. Prevent the context menu from opening. This is what the XFCE window manager does for native window borders.

The button that was clicked can be tested with event.button.

Have you considered any alternatives?

Maybe the React Re-Resizer does this properly already?. Looks like we want(ed) to migrate to this. #15083

Additional context

Left sidebar is affected too

Peek 2021-12-08 14-48

Right sidebar is affected too

Peek 2021-12-08 14-49_2

@SimonBrandner
Copy link
Contributor

I don't think I can repro to this extent but the resizer probably shouldn't react to right-click

@SimonBrandner SimonBrandner added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Dec 8, 2021
@andybalaam andybalaam added the good first issue Good for newcomers label Mar 30, 2022
@yaya-usman
Copy link
Contributor

@SimonBrandner @jaller94 i couldn't reproduce this issue, don't you think it should be closed?

@SimonBrandner
Copy link
Contributor

@SimonBrandner @jaller94 i couldn't reproduce this issue, don't you think it should be closed?

The resizer still reacts to right-click for me on Chrome (100.0.4896.60), so no, I wouldn't consider it completely fixed

@kittykat kittykat added the Help Wanted Extra attention is needed label May 4, 2022
@NSV1991
Copy link

NSV1991 commented Apr 6, 2023

Do we want the resizer to trigger only on the left mouse click?

@jaller94
Copy link
Contributor Author

Looks like the fix matrix-org/matrix-react-sdk#10546 got merged but the issue didn't get closed.

Just as a surprising side note (this is not the behaviour I expected): On XFCE/Linux, you can resize windows with both the primary and secondary mouse button. Only the tertiary (middle) muse button doesn't trigger the resizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

6 participants