Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polls are not reflected correctly in Threads #20282

Closed
kittykat opened this issue Dec 20, 2021 · 5 comments · Fixed by matrix-org/matrix-js-sdk#2165
Closed

Polls are not reflected correctly in Threads #20282

kittykat opened this issue Dec 20, 2021 · 5 comments · Fixed by matrix-org/matrix-js-sdk#2165
Assignees
@andybalaam
Labels
A-Polls A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. Create a poll, then open it in threads view (e.g. start replying in a thread)

  2. Someone else creates a poll and ends it

  3. Start a thread with the poll as a root message

  4. See that I can still "vote" in it

Outcome

What did you expect?

Threads reflects the correct state of polls

What happened instead?

Screenshot from 2021-12-20 17-26-21

Screenshot from 2021-12-20 17-24-04

Operating system

No response

Browser information

Chromium 96.0.4664.45 (Official Build) Arch Linux (64-bit)

URL for webapp

develop.element.io

Application version

Element version: dafdc1d-react-2330292c24f5-js-2aae2362e3a8 Olm version: 3.2.8

Homeserver

No response

Will you send logs?

No
@kittykat kittykat added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Threads A-Polls Z-Labs labels Dec 20, 2021
@daniellekirkwood
Copy link
Contributor

Verified with Germain today that this is still an issue: Users can still update their answers to a thread once it's ended...

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Feb 1, 2022 •
edited
Loading

Hey @andybalaam - could you help us with this?
On investigation it looks like Polls "End" don't take effect when/if there's a Thread attached to it which is causing the confusion.

Steps to reproduce:
Create Poll, Start Thread, End Poll, Switch answers :/

vs what I believe is the expected behaviour...
Create Poll, End Poll, Can't switch answers

Happy to share video/images

@andybalaam
Copy link
Contributor

Yes, I will add it to the work we have for polls, thank you @daniellekirkwood

@andybalaam
Copy link
Contributor

Hmm, vote events don't seem to show up in threads when I show hidden events:

image

@robintown robintown removed the Z-Labs label Feb 3, 2022
@germain-gg
Copy link
Contributor

germain-gg commented Feb 4, 2022 •
edited
Loading

Two other issues likely have the same root cause as what is causing the problem with polls

@andybalaam andybalaam mentioned this issue Feb 4, 2022
Merged
@germain-gg germain-gg mentioned this issue Feb 8, 2022
Merged
@HarHarLinks HarHarLinks mentioned this issue Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andybalaam andybalaam

Labels
A-Polls A-Threads O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve thread partitioning for 2nd degree relations matrix-org/matrix-js-sdk
5 participants
@kittykat @andybalaam @germain-gg @robintown @daniellekirkwood