Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink to event in unknown room leads to infinispinner #20459

Closed
richvdh opened this issue Jan 10, 2022 · 1 comment · Fixed by matrix-org/matrix-react-sdk#7501
Closed

Comments

@richvdh
Copy link
Member

richvdh commented Jan 10, 2022

Steps to reproduce

  1. Open a permalink to an event in an unknown room. For example, https://matrix.to/#/!aaa:matrix.org/$bbb?via=matrix.org. This leads a page like the following:
    image
  2. Click 'Continue' to open in Element
  3. Element-desktop switches to a spinner which never goes away:
    image

Outcome

What did you expect?

Maybe a "Click to join" button, same as when there is no event id in the permalink

What happened instead?

Infinispinner with no clue about what is happening.

Needless to say, this is a horrible UX.

Other info

console contains:

12:44:25.161 rageshake.ts:65 Routing URL  vector://vector/webapp/#/room%2F!aaa%3Amatrix.org%2F%24bbb
12:44:25.207 rageshake.ts:65 !aaa:matrix.org is current in RVS but missing from client - clearing sticky room
12:44:25.212 rageshake.ts:65 Could not restore the right panel after load because there was no associated room object.The right 
12:44:25.214 rageshake.ts:65 Switching to room id !aaa:matrix.org at event $bbb
12:44:25.304 rageshake.ts:65 newscreen room/!aaa:matrix.org/$bbb
12:44:25.359 instrument.js:268 GET https://matrix.sw1v.org/_matrix/client/r0/rooms/!aaa%3Amatrix.org/event/%24bbb 404 (Not Found)
12:44:25.360 EventUtils.ts:187 Uncaught (in promise) TypeError: Cannot read property 'threadRootId' of undefined
    at fetchInitialEvent (EventUtils.ts:187)

Probably related: matrix-org/matrix.to#235

Operating system

ubuntu 20.04

Application version

2022010901

How did you install the app?

nightly debian

Homeserver

sw1v.org

Will you send logs?

Yes

@t3chguy
Copy link
Member

t3chguy commented Jan 10, 2022

@gsouquet this looks like your thread deep-linking stuff is exploding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants