Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New search experience being a button which looks like a filter field confusing #20969

Open
t3chguy opened this issue Feb 7, 2022 · 3 comments
Labels
A-New-Search-Experience The new search dialog available in Labs T-Task Tasks for the team like planning X-Needs-Design Z-Community-Testing

Comments

@t3chguy
Copy link
Member

t3chguy commented Feb 7, 2022

The new search button resembles a text field so it's kind of confusing. I would expect a button to look more like a button and less like a form

@germain-gg germain-gg added the T-Task Tasks for the team like planning label Feb 8, 2022
@t3chguy
Copy link
Member Author

t3chguy commented Feb 8, 2022

Prior issue #20618

@ara4n
Copy link
Member

ara4n commented Feb 8, 2022

I found this super surprising too. It's fine to have the button-style hoverover, but the actual visual of the asset still looks like a text field. Button labels should surely have centered icons, whereas the left-aligned '🔍 Search' immediately evokes a search input field - as does the right-aligned ⌘K as a keyboard shortcut to navigate to that field.

@t3chguy
Copy link
Member Author

t3chguy commented Feb 8, 2022

We have other buttons without centered icons

image

But the whole content is centered at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Search-Experience The new search dialog available in Labs T-Task Tasks for the team like planning X-Needs-Design Z-Community-Testing
Projects
None yet
Development

No branches or pull requests

3 participants