Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions removed from messages in a thread by another client aren't removed in EW #21414

Closed
novocaine opened this issue Mar 14, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2246
Closed

Reactions removed from messages in a thread by another client aren't removed in EW #21414

novocaine opened this issue Mar 14, 2022 · 1 comment · Fixed by matrix-org/matrix-js-sdk#2246
Assignees
@germain-gg
Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@novocaine
Copy link
Contributor

Steps to reproduce

  1. Be in a thread with a message with a reaction
  2. Delete a reaction from one of the messages from another client

Outcome

What did you expect?

To see the reaction disappear in EW

What happened instead?

The reaction is still there until you reload the page

Operating system

OS X

Browser information

Chrome

URL for webapp

develop.element.io

Application version

Element Nightly version: 2022031001 Olm version: 3.2.8

Homeserver

matrix.org

Will you send logs?

No
@novocaine novocaine added T-Defect A-Threads S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 14, 2022
@novocaine novocaine added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed Z-Labs labels Mar 14, 2022
@novocaine
Copy link
Contributor Author

also, when I put the reaction back using the other client I can see this
Screenshot 2022-03-16 at 09 50 54

@novocaine novocaine mentioned this issue Mar 16, 2022
Closed
@germain-gg germain-gg mentioned this issue Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply redaction logic to threaded events matrix-org/matrix-js-sdk
2 participants
@novocaine @germain-gg