Fix react error on share dialog

[germain-gg]

Steps to reproduce

1. Hover over an event
2. Select "share" in the message action bar to open the share dialog

Outcome

What did you expect?

no error

What happened instead?

In the console I can see

Warning: You provided a `checked` prop to a form field without an `onChange` handler. This will render a read-only field. If the field should be mutable use `defaultChecked`. Otherwise, set either `onChange` or `readOnly`.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

[yaya-usman]

hey @gsouquet can i get assigned this issue?

[SimonBrandner]

@yaya-usman, I've assigned you to the issue. If you need any help/have any questions be sure to visit #element-dev:matrix.org!

[yaya-usman]

@SimonBrandner thanks, let me start working on it

[SimonBrandner]

Let me know if it is clearer now

[yaya-usman]

Let me know if it is clearer now

Yes,thanks

[yaya-usman]

@SimonBrandner I have fixed this issue since, but i am having issues pushing my changes to my forked version so i could make a pull request, it's giving me remote push rejected

[yaya-usman]

@SimonBrandner I have fixed this issue since, but i am having issues pushing my changes to my forked version so i could make a pull request, it's giving me remote push rejected

The thing is i only cloned the main repo the element-web and followed the guide in setting up the local version by linking matrix-react-sdk and matrix-js-sdk repos, so do i need to fork the supporting repos as well? For instance i only made changes to matrix-react-sdk, so i want to push my changes from there since element-web is linked to it, but somehow it's not working.

[SimonBrandner]

so do i need to fork the supporting repos as well?

Yes, you need to fork all the repos, if you make changes to the react-sdk, you only push the changes and make PR from there.

Though, I would suggest asking these questions in https://matrix.to/#/#element-dev:matrix.org