Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I'd like the Room Search modal to prioritize unread messages #21710

Open
sudoforge opened this issue Apr 7, 2022 · 4 comments
Open
Labels
A-New-Search-Experience The new search dialog available in Labs O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement

Comments

@sudoforge
Copy link

sudoforge commented Apr 7, 2022

Your use case

What would you like to do?

I would like the Room Search (<ctrl-k>) modal to display rooms and DMs with unread messages first, if the user has not yet entered in a search query (and perhaps consider or enable an option for "pinning" these above search results as the user types).

Why would you like to do it?

Slack has a similar feature to Room Search, which they call the "Quick Switcher". It enables similar functionality; moving between different "channels" (rooms) or direct or group messages with other users. There's a small but incredibly useful difference, though: if you have unread messages (any message in a DM or things that match your highlight rules in "channels"), those channels and DMs will be listed first in the Quick Switcher.

Implementing this behavior in the Room Search modal would improve visibility of unread messages, highlighting the "important" conversations to navigate to.

How would you like to achieve it?

I'm not sure what this question is asking. I'd like to achieve it by having it implemented. While I would be happy to help contribute, my free time is fairly limited, and I cannot commit to adding this functionality in myself at present.

Have you considered any alternatives?

#301 added functionality to navigate between rooms with unread messages, so one could make the argument that this feature request isn't valid and should be closed. I would contend that while useful, the implementation of this feature request has three advantages over the alt+ctr+{up,down} quick-navigation binding:

  • It surfaces the information to users in a relevant context: when I'm switching rooms, seeing ones that have unread messages first would add useful information to where I might choose to navigate to next.
  • It provides the information in a method with enables the user to choose where to go next, instead of moving up/down the stack as the solution to Keyboard shortcut to jump to next room with unread messages #301 provided. This provides the opportunity to the user to get to the desired unread room in a quicker manner.
  • It allows navigation to unread rooms across spaces. This enables a more fluid workflow for users, especially those who may be in many different rooms across many different spaces.

Because of these reasons, I believe that #301, while useful, ultimately fails to provide the same experience that this would.

Additional context

This might look something like this:

20220407T092338947

@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely A-New-Search-Experience The new search dialog available in Labs labels Apr 7, 2022
@github-actions github-actions bot added the Z-Labs label Apr 7, 2022
@AceTheCreator
Copy link

@dbkr Interested in this issue... Can i pick it up?

@robintown
Copy link
Member

robintown commented Apr 11, 2022

@AceTheCreator This is probably best handled as part of ongoing work to develop a search scoring system, so this issue isn't available for others to work on, currently

@robintown
Copy link
Member

I misread a bit, this is asking for discovery of unread rooms rather than prioritizing them in search results. Regardless, this needs input from design before it can be worked on.

@sudoforge
Copy link
Author

I misread a bit, this is asking for discovery of unread rooms rather than prioritizing them in search results. Regardless, this needs input from design before it can be worked on.

If we mean prioritization of rooms based on user interaction, then yes, this is about discovery rather than prioritization, although I'd wager that we'd want to block on this until after #21641 is completed, so that unread rooms can be prioritized, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-New-Search-Experience The new search dialog available in Labs O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants