Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replies to threads sent from clients without threads support appear in the thread sporadically #21803

Closed
waldyrious opened this issue Apr 14, 2022 · 4 comments
Labels
A-Threads S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@waldyrious
Copy link

Steps to reproduce

I tried the threads feature in a test conversation I had created with myself on gitter, and indeed the responses appear in the thread in both places, but on Element the Gitter messages disappeared after reloading the page. Additionally, the third thread message from Gitter appeared as a regular reply in the main timeline on Element, rather than as a thread message (the first two did appear in the thread panel in Element).

Here's what I see on Element:

image

And this is what I see on Gitter:

image

On both Element and Gitter, the situation remained the same after refreshing the page.

Outcome

What did you expect?

I expected Element to show the thread responses from Gitter normally, as they appear in the Gitter side.

What happened instead?

Threaded messages from gitter had 3 problems:

  1. they showed a quote of the previous message (i.e. as if they were replies inside the thread panel);
  2. they disappeared after refreshing the page;
  3. two of them appeared in the thread panel, but the third appeared as a reply. This is likely because it came after another Gitter reply, which, from Element's POV, does not exist — hence the error message:

    Unable to load event that was replied to, it either does not exist or you do not have permission to view it.

Operating system

Ubuntu

Browser information

Firefox 99.0

URL for webapp

https://app.element.io

Application version

Element version: 1.10.10, Olm version: 3.2.8

Homeserver

No response

Will you send logs?

Yes

@SimonBrandner
Copy link
Contributor

This seems to be a duplicate of https://gitlab.com/gitterHQ/webapp/-/issues/2830; Gitter doesn't support stable Matrix threads

@waldyrious
Copy link
Author

Oh, cool, thanks for pointing me there.

I still think that Element doesn't handle the replies sent from Gitter in a reasonable manner. Showing them in the thread panel, giving the appearance of support, but then lose track of them after a reload, doesn't seem like a good way to handle this situation.

I would rather get an error message of some kind (e.g. "unexpected message format" or something along those lines), which would be up-front and honest about what is supported or not. And the messages should definitely not disappear into the ether, either.

@robintown
Copy link
Member

Reopening this to track the reply fallback functionality for threads being unreliable

@robintown robintown reopened this Apr 15, 2022
@robintown robintown changed the title Thread messages from Gitter disapper in Element Replies to threads sent from clients without threads support appear in the thread sporadically Apr 15, 2022
@SimonBrandner SimonBrandner added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Threads labels Apr 16, 2022
@t3chguy
Copy link
Member

t3chguy commented Apr 20, 2022

Fixed by matrix-org/matrix-js-sdk#2305

@t3chguy t3chguy closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants