Move style rules of MatrixChat_useCompactLayout from _GroupLayout.scss #22434
Labels
Help Wanted
Extra attention is needed
O-Occasional
Affects or can be seen by some users regularly or most users rarely
S-Minor
Impairs non-critical functionality or suitable workarounds exist
T-Task
Tasks for the team like planning
Comments
SimonBrandner
added
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Technically,
.mx_MatrixChat_useCompactLayout .mx_EventTileis not relevant to_GroupLayout.scssso it could be moved to a corresponding SASS file, but moving the block from there to_EventTile.scsshas broken the compact layout somehow. After the incident the rule structure was analyzed and it was found out that it was due to cascading order.See: matrix-org/matrix-react-sdk#8725
Outcome
What did you expect?
The style block
.mx_MatrixChat_useCompactLayout .mx_EventTileshould not belong to_GroupLayout.scssas the block is not included in.mx_GroupLayoutselector, which was removed recently.What happened instead?
Moving the block from
_GroupLayout.scssto_EventTile.scsshas broken the compact layout because of cascading order.Operating system
No response
Browser information
No response
URL for webapp
No response
Application version
develop branch
Homeserver
No response
Will you send logs?
No
The text was updated successfully, but these errors were encountered: