Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login form's placeholder switches between upper and lower case #22813

Closed
HarHarLinks opened this issue Jul 11, 2022 · 6 comments · Fixed by matrix-org/matrix-react-sdk#9329
Closed
Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Design

Comments

@HarHarLinks
Copy link
Contributor

Steps to reproduce

  1. Go to login screen
  2. position cursor inside username field
  3. watch Username get lowercased

Outcome

What did you expect?

Username appears multiple times, including as a placeholder in the input field. upon entering the field, it should not change, but only disappear once you start typing. The password field has this behaviour.

What happened instead?

image

In a i18n such as 🇩🇪, nouns are generally spelled with an upper case first letter. Here, converting to lower is even more wrong compared to the fact that all your other labels stick to upper case:
image

Might be caused by:
https://github.com/matrix-org/matrix-react-sdk/blob/d599b1b206dba16fecdaf1824e2de38a302e4b60/src/components/views/auth/PasswordLogin.tsx#L317

Operating system

arch

Application version

Element Nightly version: 2022071101 Olm version: 3.2.8

How did you install the app?

aur

Homeserver

No response

Will you send logs?

No

@robintown
Copy link
Member

If I recall, this is done as a subtle hint that the username needs to be all lowercase. It is weird though.

@robintown robintown added S-Tolerable Low/no impact on users A-Login X-Needs-Design O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 11, 2022
@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2022

Duplicate of #21820

@t3chguy t3chguy marked this as a duplicate of #21820 Jul 12, 2022
@t3chguy t3chguy closed this as completed Jul 12, 2022
@RiotRobot RiotRobot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
@HarHarLinks
Copy link
Contributor Author

You could mark this as duplicate, but what #21820 fails to point out is that this input field's behaviour in particular makes no sense. Even if it is intended to be lower case, then the unselected state is defective:
image

@HarHarLinks
Copy link
Contributor Author

HarHarLinks commented Jul 12, 2022

@t3chguy

Duplicate of #21820

sorry, I think there is some confusion. Though related, I wouldn't consider this a dupe.

That issue is about the registration form and the UX around creating only new lowercase MXIDs. This issue here is about the login form and capitalization of the placeholder at a point where the capitalization of the placeholder is simply irrelevant because users already need to remember the spelling of their names anyway. The only thing I think you could do is upon failed login attempt with upper case letters, include in the error message to perhaps try lower case, or try that automatically.

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2022

Yes, but the reason it is lowercase is as a failed solution to #21820 - so closing as duplicate to find a better solution and revert this one.

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2022

Oh my bad on registration vs login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Login O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants