Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrolling in the main timeline while keeping a thread with a mention open increases the notification count #23721

Closed
robintown opened this issue Nov 7, 2022 · 2 comments
Closed

Scrolling in the main timeline while keeping a thread with a mention open increases the notification count #23721

robintown opened this issue Nov 7, 2022 · 2 comments
Assignees
@germain-gg
Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Clear all your notifications in a room
  2. Open a thread in that room where you were previously mentioned and notified
  3. Scroll backwards through the main timeline of the room

Outcome

What did you expect?

The notification count should stay at zero

What happened instead?

The room gets a red badge, and the notification count for the room seems to increase by 1 for every new event loaded into the main timeline

Operating system

NixOS unstable

Browser information

Firefox 106.0.2

URL for webapp

develop.element.io

Application version

Element version: 65b8bc1-react-36a574a14fa7-js-6c543382e665 Olm version: 3.2.12

Homeserver

Synapse 1.70.1

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads labels Nov 7, 2022
@germain-gg germain-gg self-assigned this Nov 8, 2022
@germain-gg germain-gg mentioned this issue Nov 8, 2022
Merged
3 tasks
@germain-gg
Copy link
Contributor

I have been unable to reproduce with the steps you gave, there must be other forces at play that I have not figured out yet, but I have a PR up that could make this a tiny bit better, matrix-org/matrix-js-sdk#2862

Would you be able to check the Netlify build at some point?

@robintown
Copy link
Member Author

Fixed by matrix-org/matrix-js-sdk#2862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Notifications A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@germain-gg @robintown