You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There should be a cypress test for ReplyChain to make a percy test for changes proposed by a PR like matrix-org/matrix-react-sdk#8972
Why would you like to do it?
Because it really is easy to cause a regression due to the nature of _components.pcss, which simply imports styles alphabetically without considering the semantic order in which styles should cascade and be inherited. Therefore, generally speaking, even moving a style block from one *.pcss file to another may cause a regression like this, unless you recognize the cascading order perfectly clear, which is hard for not only those who are not familiar with the style structure but also a team member/reviewer.
How would you like to achieve it?
Either by creating a cypress test for ReplyChain to let a percy test or an alternative tool check for you, whether or not the current codebase works as expected or by refactoring _components.pcss to have it respect the cascading order in order to improve the codebase and reduce dependency on an external tool like percy or by creating UI based on a brand new style codebase.
Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Your use case
What would you like to do?
There should be a cypress test for
ReplyChain
to make a percy test for changes proposed by a PR like matrix-org/matrix-react-sdk#8972Why would you like to do it?
Because it really is easy to cause a regression due to the nature of _components.pcss, which simply imports styles alphabetically without considering the semantic order in which styles should cascade and be inherited. Therefore, generally speaking, even moving a style block from one *.pcss file to another may cause a regression like this, unless you recognize the cascading order perfectly clear, which is hard for not only those who are not familiar with the style structure but also a team member/reviewer.
How would you like to achieve it?
Either by creating a cypress test for
ReplyChain
to let a percy test or an alternative tool check for you, whether or not the current codebase works as expected or by refactoring_components.pcss
to have it respect the cascading order in order to improve the codebase and reduce dependency on an external tool like percy or by creating UI based on a brand new style codebase.Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: