Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percy snapshot tests for permalink pills #24889

Closed
weeman1337 opened this issue Mar 22, 2023 · 1 comment
Closed

Percy snapshot tests for permalink pills #24889

weeman1337 opened this issue Mar 22, 2023 · 1 comment
Labels
A-Pills A-Testing Testing, code coverage, etc. T-Task Tasks for the team like planning

Comments

@weeman1337
Copy link
Contributor

Your use case

There should be Percy snapshot tests for permalink pills:

  • @room mention
  • User in same room
  • Unknown user
  • Link to a known room
  • Link to a room, that has not been joined
  • Message in the same room
  • Message in other room
  • Message in a room, that has not been joined
  • Link to a message in same room, where the event Id does not exist (for instance if a user has been ignored)

Have you considered any alternatives?

No response

Additional context

No response
@weeman1337 weeman1337 mentioned this issue Mar 22, 2023
Merged
3 tasks
@robintown robintown added T-Task Tasks for the team like planning A-Pills A-Testing Testing, code coverage, etc. and removed T-Enhancement labels Mar 22, 2023
@weeman1337
Copy link
Contributor Author

Closed by matrix-org/matrix-react-sdk#10434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Pills A-Testing Testing, code coverage, etc. T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weeman1337 @robintown